SNOW-2199122 Replace is_datetime64tz_dtype with isinstance to resolve pandas deprecation warning #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
michaelxfrench
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2199122: pandas DeprecationWarning: is_datetime64tz_dtype is deprecated and will be removed in a future version #2399
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
In my PR, I have replaced the call to
pandas.api.types.is_datetime64tz_dtype(df[c])withisinstance(df[c], pandas.DatetimeTZD)as suggested by the pandas deprecation message.I have also made a couple of updates in the documentation bumping the python version in tox calls to the lowest supported python version for the project as mentioned in
setup.cfg. There is still one reference to py38 in the pyupgrade section of the.pre-commit-config.yamlwhich I did not change since it would add more noise to the diffs of this PR, but will happily add it if the reviewers are okay with the additional changes.